Resolved issues rasied #1611 , #1628 , #1602#1637
Open
cropsgg wants to merge 3 commits into
Open
Conversation
…1611) `/sync-gbrain --full` on ~100k-page brains reliably exceeded the hard-coded 35-minute timeout, SIGTERMed mid-import, and lost the staging checkpoint. Set GSTACK_SYNC_MEMORY_TIMEOUT_MS (or _CODE_ for the code stage) to override; bad input falls back to the 35-min default with a stderr warning so a typo can't silently disable the safety net.
Codex CLI defaults to gpt-5.2-codex, which OpenAI's ChatGPT-account
entitlement filter rejects with a 400 ("model is not supported when
using Codex with a ChatGPT account"). Every skill that shells out to
codex — /codex, /autoplan, /plan-eng-review, /ship, /plan-ceo-review,
/plan-design-review — broke for ChatGPT-only auth users.
Add _gstack_codex_account_kind (apikey | chatgpt | none) and
_gstack_codex_default_model_args to bin/gstack-codex-probe. Templates
expand $_CODEX_MODEL_ARGS=$(_gstack_codex_default_model_args) before
every codex invocation; API-key users get nothing extra, ChatGPT users
get `-m gpt-5.2`. $GSTACK_CODEX_MODEL overrides; set to "default" to
opt out of injection entirely.
Wired at all 9 callsites across codex/SKILL.md.tmpl (5) and
autoplan/SKILL.md.tmpl (4). A static template guard test catches a
future edit that drops the variable.
Issue garrytan#1602's package.json fix landed in garrytan#1594, but the regression test was string-matching only. Exercise scripts/build.sh and scripts/write-version-files.sh via `bash -n` (syntax check) and a real invocation against tmpdir targets; also expand the package.json guard to cover every bunsh-incompatible construct (subshells-with-redirection, multi-redirection, brace groups, process substitution) in one place. Catches a future edit that re-introduces any of them without needing a Windows runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here are the solutions that I did :
/sync-gbrain --fullon ~100k-page brains reliably exceeded thehard-coded 35-minute timeout, SIGTERMed mid-import, and lost the staging
checkpoint. Set GSTACK_SYNC_MEMORY_TIMEOUT_MS (or CODE for the code
stage) to override; bad input falls back to the 35-min default with a
stderr warning so a typo can't silently disable the safety net.
Codex CLI defaults to gpt-5.2-codex, which OpenAI's ChatGPT-account
entitlement filter rejects with a 400 ("model is not supported when
using Codex with a ChatGPT account"). Every skill that shells out to
codex — /codex, /autoplan, /plan-eng-review, /ship, /plan-ceo-review,
/plan-design-review — broke for ChatGPT-only auth users.
Add _gstack_codex_account_kind (apikey | chatgpt | none) and$_CODEX_MODEL_ARGS=$ (_gstack_codex_default_model_args) before
_gstack_codex_default_model_args to bin/gstack-codex-probe. Templates
expand
every codex invocation; API-key users get nothing extra, ChatGPT users
get
-m gpt-5.2. $GSTACK_CODEX_MODEL overrides; set to "default" toopt out of injection entirely.
Wired at all 9 callsites across codex/SKILL.md.tmpl (5) and
autoplan/SKILL.md.tmpl (4). A static template guard test catches a
future edit that drops the variable.
bun run buildaborts — package.json build script uses redirection constructs bunsh rejects; regression test only checks statically #1602 package.json fix landed in v1.42.0.0 Daegu wave: 23 community-filed bugs + PTY classifier enforcement (24 bisect commits) #1594, but the regression testwas string-matching only. Exercise scripts/build.sh and
scripts/write-version-files.sh via
bash -n(syntax check) and a realinvocation against tmpdir targets; also expand the package.json guard
to cover every bunsh-incompatible construct (subshells-with-redirection,
multi-redirection, brace groups, process substitution) in one place.
Catches a future edit that re-introduces any of them without needing a
Windows runner.
if useful kindly merge