Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically reverts the integration of the 'Relay' swap provider, which was initially part of a larger feature. The primary goal is to modularize the Relay functionality, allowing for its re-introduction in smaller, more manageable development phases. This involves a comprehensive removal of all Relay-specific code, dependencies, and related transaction handling logic for Bitcoin and Solana across multiple crates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the relay feature, removing a significant amount of code and dependencies, and also refactors the Relay provider to use the ProxyProvider pattern. My review has identified a potential regression where the timeout for fetching quotes from providers has been removed, which could cause the system to hang. I've also noted a functional change to the Relay provider's supported chains that seems out of place for a revert PR and may need clarification.
Note: Security Review did not run due to the size of the PR.
…elay # Conflicts: # crates/swapper/src/relay/asset.rs # crates/swapper/src/relay/mapper.rs # crates/swapper/src/relay/mod.rs # crates/swapper/src/relay/model.rs # crates/swapper/src/relay/provider.rs # crates/swapper/src/relay/testkit.rs
# Conflicts: # crates/swapper/src/relay/asset.rs # crates/swapper/src/relay/mapper.rs # crates/swapper/src/relay/mod.rs # crates/swapper/src/relay/model.rs # crates/swapper/src/relay/provider.rs # crates/swapper/src/relay/testkit.rs
Introduce a new Relay integration and expose vault addresses via the API. Adds a relay module (asset, chain, mapper, model, testkit, and testdata) to map Relay API responses into internal SwapResult metadata and to fetch solver/vault addresses. Integrates Relay into the proxy provider to return swap results and vault addresses from the relay service. Adds GET /chain/swaps/<provider>/vault_addresses endpoint to the API. Refactors cross-chain detection to rely on a VaultAddressMap (removing the old per-provider CrossChainProvider trait and hardcoded provider detectors) and updates tests accordingly. Also adds treasury addresses to NearIntents as default vault addresses and applies small imports/formatting cleanups across providers.
2 participants
This fixes swap status for Relay, and only keep EVM for now