feat: python code interpreter improvements#1190
Conversation
Tool PR ChecklistUse this checklist when adding or modifying tools in Protocol Compliance
Integration
|
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
|
Addressed the review feedback, also rebased on main go avoid some of the CI issues we ran into yesterday. |
ajbozarth
left a comment
There was a problem hiding this comment.
Some feedback from Claude — re-reviewed, the 10 prior items are addressed. Three new RST holdouts inline (Example::, two .. deprecated::) — non-blocking, fits naturally into the docstring-sweep work item you just picked up. Worth folding "no RST in Google-style docstrings" into AGENTS.md as part of that.
| a normal mellea installation). | ||
| ValueError: If any entry in `packages` is empty or begins with `-`. | ||
|
|
||
| Example:: |
There was a problem hiding this comment.
Per CONTRIBUTING.md, docstrings are Google-style — Example:: is RST. Should be a single colon (the indented block under it is already fine).
| Example:: | |
| Example: |
Heads up: since you just picked up the double-backtick docstring sweep, worth widening the scope to catch RST stragglers like this and the two .. deprecated:: blocks below in the same pass — and adding a line to AGENTS.md so the policy is "Google-style only, no RST" rather than just "no double backticks." Happy to defer all three to that work item.
| .. deprecated:: | ||
| Use :func:`python_tool` instead:: |
There was a problem hiding this comment.
Same RST-vs-Google issue — .. deprecated:: is a Sphinx directive and the trailing :: on instead:: is an RST literal block. Google style uses a Deprecated: section.
| .. deprecated:: | |
| Use :func:`python_tool` instead:: | |
| Deprecated: | |
| Use `python_tool` instead: |
Same pattern at line 1227-1228 below. Roll into the docstring sweep.
| .. deprecated:: | ||
| Use :func:`python_tool` instead:: |
There was a problem hiding this comment.
| .. deprecated:: | |
| Use :func:`python_tool` instead:: | |
| Deprecated: | |
| Use `python_tool` instead: |
|
Sounds good, will merge as is and then pick up related doc string / AGENTS.md update in #1172 |
Pull Request
Issue
Fixes #1022
Description
Updates the code interpreter to allow running in sandbox with packages and allow file output - ie matplotlib
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.