fix: remove drift detection from intrinsic tests and pin tests to SHAs#1196
Conversation
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com> Assisted-by: CLAUDE:OPUS
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
19cb7e3 to
d72d408
Compare
|
Quick review from Claude found a few items worth noting but nothing blocking: A few optional follow-ups, nothing blocking:
|
|
It looks like the CI is hitting the same issue on all the PRs again: =========================== short test summary info ============================
ERROR test/stdlib/components/docs/test_richdocument.py::test_richdocument_basics - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while trying to locate the files on the Hub and we cannot find the appropriate snapshot folder for the specified revision on the local disk. Please check your internet connection and try again.
ERROR test/stdlib/components/docs/test_richdocument.py::test_richdocument_markdown - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while trying to locate the files on the Hub and we cannot find the appropriate snapshot folder for the specified revision on the local disk. Please check your internet connection and try again.
ERROR test/stdlib/components/docs/test_richdocument.py::test_richdocument_save - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while trying to locate the files on the Hub and we cannot find the appropriate snapshot folder for the specified revision on the local disk. Please check your internet connection and try again.
ERROR test/stdlib/components/docs/test_richdocument.py::test_table - huggingface_hub.errors.LocalEntryNotFoundError: An error happened while trying to locate the files on the Hub and we cannot find the appropriate snapshot folder for the specified revision on the local disk. Please check your internet connection and try again.
ERROR test/stdlib/requirements/test_groundedness_requirement.py::test_groundedness_requirement_allow_partial_support_parameter - OSError: We couldn't connect to 'https://huggingface.co/' to load the files, and couldn't find them in the cached files.
Check your internet connection or see how to run the library in offline mode at 'https://huggingface.co/docs/transformers/installation#offline-mode'.
= 2423 passed, 230 skipped, 21 deselected, 1 xfailed, 1 xpassed, 521 warnings, 5 errors in 1036.27s (0:17:16) =I think these just need the same fix as @planetf1 made in #1195 |
ajbozarth
left a comment
There was a problem hiding this comment.
Adding an approval to unblock merge since my previous review is non-blocking and the CI failure is flakey and probably better to solve in another PR
(@planetf1 you may to take a look at the CI failure point above in the morning)
|
@ajbozarth taking a look |
|
Thanks @ajbozarth — opened #1199 which centralises the skip guard into a single |
Co-authored-by: Nigel Jones <nigel.l.jones+git@gmail.com> Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
a6c5138 to
80ad675
Compare
|
@planetf1, applied the change. I will need your review to get this merged since it requires an intrinsics maintainer. |
Pull Request
Issue
Fixes N/A
Description
Removes drift detection from each individual adapter. Instead, pins each repo to a single sha to reduce downloads and improve caching. This SHA is retrieved from the SHA used in our catalog pinning.
Changes the adapter change test to work off the repo SHA. Nightlies may fail more often but it will keep us up to date.
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.