feat: add matplotlib requirements#1208
Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Requirement PR ChecklistUse this checklist when adding or modifying requirements in Base Class
Validation Logic
Integration
|
ajbozarth
left a comment
There was a problem hiding this comment.
Some feedback from Claude — follow-ups inline.
planetf1
left a comment
There was a problem hiding this comment.
A few additional findings alongside @ajbozarth's review.
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
ajbozarth
left a comment
There was a problem hiding this comment.
LGTM — all 17 review threads addressed, tests pass locally (24 passed, 1 xfailed).
Re: the xfail on test_valid_dependencies_available — you're right, my earlier comment was wrong. matplotlib isn't in pyproject.toml, leave xfail as-is.
Two small nits inline, neither blocking.
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Pull Request
Issue
Fix: #1120
Description
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.