Skip to content

feat: add matplotlib requirements#1208

Open
akihikokuroda wants to merge 7 commits into
generative-computing:mainfrom
akihikokuroda:matplotlib
Open

feat: add matplotlib requirements#1208
akihikokuroda wants to merge 7 commits into
generative-computing:mainfrom
akihikokuroda:matplotlib

Conversation

@akihikokuroda
Copy link
Copy Markdown
Member

@akihikokuroda akihikokuroda commented Jun 5, 2026

Pull Request

Issue

Fix: #1120

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code was added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Adding a new component, requirement, sampling strategy, or tool?

If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.

  • Component
  • Requirement
  • Sampling Strategy
  • Tool

NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda requested a review from a team as a code owner June 5, 2026 01:12
@akihikokuroda akihikokuroda marked this pull request as draft June 5, 2026 01:12
@github-actions github-actions Bot added the enhancement New feature or request label Jun 5, 2026
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

This comment is managed by a bot. Editing it is fine — checking off boxes, adding notes — but please leave the HTML comment marker on the first line alone, otherwise checklist updates will break.

Requirement PR Checklist

Use this checklist when adding or modifying requirements in mellea/stdlib/requirements/.

Base Class

  • Extends appropriate base class:
    • Requirement - standard requirement
    • ALoraRequirement - uses specialized Intrinsic/Adapter for generation-based validation

Validation Logic

  • validation_fn defined (if using Python-based validation)
    • re-usable functionality within the validation_fn should be separated out into mellea/stdlib/tools/
  • validate returns a ValidationResult with
    • a thunk and context if using a backend to generate
    • a specific reason and score when possible

Integration

  • Requirement exported in mellea/stdlib/requirements/__init__.py or, if you are adding a library of requirements, from your sub-module

@akihikokuroda akihikokuroda marked this pull request as ready for review June 5, 2026 14:47
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback from Claude — follow-ups inline.

Comment thread docs/examples/requirements/README.md Outdated
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py Outdated
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py Outdated
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py
Comment thread docs/examples/requirements/matplotlib_plotting.py Outdated
Copy link
Copy Markdown
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few additional findings alongside @ajbozarth's review.

Comment thread mellea/stdlib/requirements/plotting/matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py Outdated
Comment thread mellea/stdlib/requirements/plotting/matplotlib.py Outdated
Comment thread docs/examples/requirements/README.md Outdated
Comment thread docs/examples/requirements/README.md Outdated
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda requested a review from ajbozarth June 5, 2026 18:19
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda requested review from planetf1 June 5, 2026 18:52
Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all 17 review threads addressed, tests pass locally (24 passed, 1 xfailed).

Re: the xfail on test_valid_dependencies_available — you're right, my earlier comment was wrong. matplotlib isn't in pyproject.toml, leave xfail as-is.

Two small nits inline, neither blocking.

Comment thread docs/examples/requirements/matplotlib_plotting.py Outdated
Comment thread test/stdlib/requirements/plotting/test_matplotlib.py
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requirements Library: Implement matplotlib-specific requirements

3 participants