Skip to content

fix: python decompose model change and pipeline fix#569

Open
AngeloDanducci wants to merge 3 commits intogenerative-computing:mainfrom
AngeloDanducci:ad-decompose-model-change
Open

fix: python decompose model change and pipeline fix#569
AngeloDanducci wants to merge 3 commits intogenerative-computing:mainfrom
AngeloDanducci:ad-decompose-model-change

Conversation

@AngeloDanducci
Copy link
Contributor

@AngeloDanducci AngeloDanducci commented Mar 3, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@AngeloDanducci AngeloDanducci requested a review from a team as a code owner March 3, 2026 15:39
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Mar 3, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@AngeloDanducci
Copy link
Contributor Author

@psschwei that issue you ran into should be solved with this update

@csbobby could use your feedback as well, the change in cli/decompose/pipeline.py assigns a validation strategy of llm if none exists - though I think the more correct long term change is probably to pass the validation strategy down when breaking up constraints. Prior to #445 a single constraint would not be broken down so this was a non issue.

It looks like this area is getting reworked in #556 so maybe this is fine in the interim.

Comment on lines +145 to +147
"validation_strategy": constraint_validation_strategies.get(
cons_str, "llm"
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csbobby, can you please confirm that you are okay with changing this and always having an LLM default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants