Add install-owned event prompts for Slack root messages#475
Open
dcramer wants to merge 7 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dcramer
force-pushed
the
codex/refine-plugin-event-plan
branch
from
f2c5047 to
5d6f618
Compare
dcramer
force-pushed
the
codex/refine-plugin-event-plan
branch
from
02d0829 to
32a1acf
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1d8da0. Configure here.
| binding: match.binding, | ||
| definition: match.definition, | ||
| envelope, | ||
| }); |
There was a problem hiding this comment.
Render error skips other bindings
Medium Severity
When one matched binding’s renderContextBlocks throws, the whole dispatchEventPromptRuns loop aborts, so other bindings that matched the same envelope never get a dispatch.
Reviewed by Cursor Bugbot for commit d1d8da0. Configure here.
Add version-controlled event prompt bindings and the first Slack root-message event producer. Route matching events through core dispatch with idempotency and explicit Slack mention suppression. Also keep the example build test in sync with the dashboard trusted plugin package after rebasing onto main. Refs GH-435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Initialize the Slack adapter before passive event prompt extraction so cold starts can discover the bot user id. Run multi-workspace event dispatch inside the resolved Slack installation context so ambient channel events do not fail closed incorrectly. Refs GH-435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Let event prompt dispatches complete without visible Slack delivery when the agent returns no assistant-visible text or files. Block Slack mutating and schedule-management tools for event prompt runs until binding-level tool policy is implemented below the model. Share Slack side-channel installation context handling across edited mentions and event prompts so Enterprise Grid installs resolve through the enterprise installation. Refs GH-435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Add app-level coverage for install-owned event prompt bindings and tighten Slack event prompt tests so they avoid leaking process state or asserting prompt scaffolding. Document the event observability boundary around sparse logs and lifecycle spans. Refs #435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Move Slack-specific webhook body handling into a route submodule and keep the generic webhook handler focused on platform dispatch. Remove unsupported event prompt policy fields from the frontmatter schema so future behavior is not reserved without executor enforcement. Refs #435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Remove delivery targets and declarative filters from the first event prompt API. The current Slack event prompt path derives delivery from the Slack event envelope and only needs event id, scope, context blocks, and a prompt body. Refs #435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
Keep event prompt dispatches on the runtime-bound options type after delegated credential support split plugin input from persisted dispatch records. This preserves the no-credential event prompt path without widening createOrGetDispatch. Refs GH-435 Co-Authored-By: GPT-5 Codex <codex@openai.com>
dcramer
force-pushed
the
codex/refine-plugin-event-plan
branch
from
71e21f8 to
bc0de22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/events/**/*.mdslack.channel.message.createdevent and dispatch it for new root channel messages, while skipping thread replies and direct mention conflictsTesting