Skip to content

fix(dashboard): Align plugin reports empty state #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcramer merged 1 commit into from
Jun 5, 2026
+5 −9
Merged

fix(dashboard): Align plugin reports empty state #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/junior-dashboard/src/client/components/PluginReports.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function PluginReports(props: {
<SectionHeader>
<SectionTitle>Plugin Reports</SectionTitle>
</SectionHeader>
<div className="px-4 pb-4 text-[0.84rem] leading-relaxed text-[#888]">
<div className="px-4 py-4 text-[0.84rem] leading-relaxed text-[#888]">
{props.emptyText}
</div>
</Section>
Expand Down
2 changes: 1 addition & 1 deletion packages/junior-dashboard/src/client/pages/PluginsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function PluginsPage(props: { data?: DashboardData }) {
? undefined
: reportsLoading
? "Loading trusted plugin stats."
: "No trusted plugin stats have been reported yet.";
: "No plugins have been reported yet.";

return (
<div className="mx-auto w-full min-w-0 max-w-screen-xl px-4 py-4 md:px-8">
Expand Down
10 changes: 3 additions & 7 deletions packages/junior-dashboard/tests/telemetry-components.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@ describe("dashboard telemetry components", () => {

expect(html).toContain(">Plugins<");
expect(html).toContain("github");
expect(html).toContain("No trusted plugin stats have been reported yet.");
expect(html).toContain("No plugins have been reported yet.");
});

it("shows plugin reports as loading before the report query returns", () => {
Expand All @@ -653,9 +653,7 @@ describe("dashboard telemetry components", () => {
expect(html).toContain(">...<");
expect(html).toContain(">loading<");
expect(html).not.toContain(">none<");
expect(html).not.toContain(
"No trusted plugin stats have been reported yet.",
);
expect(html).not.toContain("No plugins have been reported yet.");
});

it("shows plugin report failures without looking empty", () => {
Expand All @@ -669,9 +667,7 @@ describe("dashboard telemetry components", () => {
);

expect(html).toContain("Trusted plugin stats failed to load.");
expect(html).not.toContain(
"No trusted plugin stats have been reported yet.",
);
expect(html).not.toContain("No plugins have been reported yet.");
});

it("shows plugin report failures while keeping stale reports visible", () => {
Expand Down
Loading