Skip to content

rfc(decision): Merge sentry-javascript-bundler-plugins into sentry-javascript#149

Open
chargome wants to merge 7 commits intomainfrom
cg/merge-bundler-plugins
Open

rfc(decision): Merge sentry-javascript-bundler-plugins into sentry-javascript#149
chargome wants to merge 7 commits intomainfrom
cg/merge-bundler-plugins

Conversation

@chargome
Copy link
Member

@chargome chargome commented Jan 23, 2026

@chargome chargome self-assigned this Jan 23, 2026
@linear
Copy link

linear bot commented Jan 23, 2026

@chargome chargome force-pushed the cg/merge-bundler-plugins branch from 93617a9 to ed5d1f8 Compare February 2, 2026 12:33
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing up the RFC and addressing feedback. I think we have our decision. Only had one question left.


1. **Update dependencies**:
- Bump minimum Node.js to 18+
- Migrate unplugin to v2 (drops Node 16 and Webpack 4 support)
Copy link
Member

@Lms24 Lms24 Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Did we land on upgrading vs. removing unolugin in favour of native plugins?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated! We'll drop unplugin and keep webpack 4 – win win

Copy link
Contributor

@timfish timfish Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that webpack v4 doesn't run on Node >= v18 because v18 removed support for the MD4 hashing algorithm it used. By updating our supported Node to >= 18 we will effectively be dropping webpack v4 support too!

@chargome chargome marked this pull request as ready for review February 2, 2026 14:33
@timfish
Copy link
Contributor

timfish commented Feb 9, 2026

Just some other things I've noticed while working in the repo:

  • We currently use Rollup v2 to build the packages (likely to support Node v14). We likely want to use something newer when we can!
  • e2e/integrations tests aren't isolated and test the wrong bundler versions
    • We should not be calling the bundlers from code. This is not isolated and has caused a number of issues.
    • Our Rollup tests currently only test Rollup v2 because that is what we use to bundle the packages and it gets picked up. We don't even support Rollup v2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants