feat: update user permission protocol for github#90
Draft
joseph-sentry wants to merge 1 commit into
Draft
Conversation
since github's and gitlab's endpoints for user permissions take in different IDs to discern the user github accepting the username, and gitlab accepting the user's internal ID, it was unclear what to do at the protocol level: should we make 2 separate protocols since the ID arg is "different" between the 2 providers? or should we make a single protocol and its implicit that gitlab and github use different values to fix this problem im proposing to have the protocol take in the Author type from within the SCM platform which contains both pieces of information either provider would need so we can have a single protocol that takes in the same value for either provider and the decision to use either the id or username is encapsulated i tested the gitlab and github endpoints locally using server and clients in bin/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since github's and gitlab's endpoints for user permissions take in different IDs to discern the user
github accepting the username, and gitlab accepting the user's internal ID, it was unclear what to do
at the protocol level: should we make 2 separate protocols since the ID arg is "different" between the
2 providers? or should we make a single protocol and implicitly accept that gitlab and github use different
values
to fix this i propose the protocol take in the SCM platform Author type
which contains all information either provider needs so we can have a single protocol that works for both providers
i tested the gitlab and github endpoints locally using server and clients in bin/