-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Add a common ground for SDKs and their env variables handling #16326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this into develop, not the customer docs.
Client-side paragraph sounds correct to me, thanks! |
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
It was not possible to use env variables for the Cloudflare SDK. This adds a subset of env variables to enable certain features just with env variables (not everything is yet supported - we should wait what gets supported once [that PR lands](getsentry/sentry-docs#16326)). This PR is important for #19215.
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding 🏄♂️
DESCRIBE YOUR PR
This adds a common understanding of which environment variables should be available across all SDKs (origin of the idea: getsentry/rfcs#121). I added couple of SDKs with a tiny example, so we don't show just one
There are still options missing, which could be added in the future (or now if we are already sure it is a good idea to add now):
SENTRY_BREADCRUMBS_LOGS_ENABLEDSENTRY_TRACE_MISSING_ROUTES_ENABLEDFollowing was taken as example: https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/
(added @Lms24 because of the client-side specifics)
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES