fix(rust-sdk): Correct the criteria for sending request body#16342
Merged
szokeasaurusrex merged 1 commit intomasterfrom Feb 11, 2026
Merged
fix(rust-sdk): Correct the criteria for sending request body#16342szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex merged 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
91fcd8f to
35de74d
Compare
35de74d to
aefc6c7
Compare
aefc6c7 to
7a56003
Compare
cleptric
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the Rust Actix request-body documentation, which previously incorrectly stated that
send_default_pii = falseprevents request bodies from being sent. In fact,send_default_piionly restricts the captured content types, but does not fully prevent request bodies from being sent.Explanation
send_default_piiis read in middleware viaclient.options().send_default_pii, stored in a localwith_pii, and then passed as thewith_piiparameter toshould_capture_request_body. Inside that function, the parameter is used in theis_valid_content_typebranch, wheresend_default_pii = falserestricts body capture to exactapplication/jsonandapplication/x-www-form-urlencoded, whilesend_default_pii = trueallows any content type.should_capture_request_bodyalso checks transfer encoding,Content-Length, andmax_request_body_size;SentryMiddleware::callthen checksshould_capture_request_body's return value to determine whether to capture the request body. Sosend_default_piiaffects content-type eligibility, but is not a hard on/off switch for request body capture.