test(metrics): Trace-connected Metrics (Tests)#4839
Merged
Flash0ver merged 3 commits intofeat/trace-connected-metricsfrom Jan 29, 2026
Merged
test(metrics): Trace-connected Metrics (Tests)#4839Flash0ver merged 3 commits intofeat/trace-connected-metricsfrom
Flash0ver merged 3 commits intofeat/trace-connected-metricsfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/trace-connected-metrics #4839 +/- ##
================================================================
+ Coverage 72.58% 73.79% +1.20%
================================================================
Files 495 495
Lines 17893 17893
Branches 3523 3523
================================================================
+ Hits 12988 13204 +216
+ Misses 4048 3829 -219
- Partials 857 860 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
I think we should merge this into #4834 before that PR is merged itself... if the tests in this branch break, we wouldn't want to merge that PR - so they're tightly coupled by nature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on
Split into a separate PR, hoping to simplify reviews and discussion.
Heavily based on the tests for Sentry Structured Logging.
#skip-changelog