Skip to content

ci: Fix Spring Boot matrix version updates#5372

Draft
adinauer wants to merge 2 commits intomainfrom
ci/fix-spring-boot-matrix-version-sed
Draft

ci: Fix Spring Boot matrix version updates#5372
adinauer wants to merge 2 commits intomainfrom
ci/fix-spring-boot-matrix-version-sed

Conversation

@adinauer
Copy link
Copy Markdown
Member

@adinauer adinauer commented May 6, 2026

📜 Description

Fix the Spring Boot 2.x, 3.x, and 4.x matrix workflows so their version override matches the TOML version catalog format.

The workflows now preserve whitespace around the assignment and replace the quoted Spring Boot version value in gradle/libs.versions.toml.

💡 Motivation and Context

The existing sed expressions looked for keys without spaces around =, but the version catalog uses entries like springboot2 = "2.7.18". As a result, matrix jobs did not actually update the Spring Boot version under test.

💚 How did you test it?

  • Ran the updated sed expressions against a temporary copy of gradle/libs.versions.toml and verified Spring Boot 2, 3, and 4 versions were updated.
  • Ran ./gradlew spotlessApply apiDump.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

Match the TOML version catalog format when overriding Spring Boot versions in matrix jobs. Preserve whitespace around the assignment and replace the quoted version value so the CI jobs actually test the requested matrix version.

Co-Authored-By: Claude <noreply@anthropic.com>
@sentry
Copy link
Copy Markdown

sentry Bot commented May 6, 2026

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.40.0 (1) release

⚙️ sentry-android Build Distribution Settings

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 312.21 ms 351.30 ms 39.09 ms
Size 0 B 0 B 0 B

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2195398 319.02 ms 342.38 ms 23.36 ms
d364ace 411.72 ms 430.81 ms 19.10 ms
d15471f 286.65 ms 314.68 ms 28.03 ms
ff8eea4 313.42 ms 337.08 ms 23.66 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
23d6b12 354.10 ms 408.38 ms 54.28 ms
cf708bd 408.35 ms 458.98 ms 50.63 ms
6edfca2 305.52 ms 432.78 ms 127.26 ms
72020f8 312.32 ms 370.94 ms 58.62 ms
6b019b7 343.31 ms 417.23 ms 73.91 ms

App size

Revision Plain With Sentry Diff
2195398 0 B 0 B 0 B
d364ace 1.58 MiB 2.11 MiB 539.75 KiB
d15471f 1.58 MiB 2.13 MiB 559.54 KiB
ff8eea4 1.58 MiB 2.28 MiB 718.64 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
cf708bd 1.58 MiB 2.11 MiB 539.71 KiB
6edfca2 1.58 MiB 2.13 MiB 559.07 KiB
72020f8 1.58 MiB 2.19 MiB 620.21 KiB
6b019b7 0 B 0 B 0 B

Previous results on branch: ci/fix-spring-boot-matrix-version-sed

Startup times

Revision Plain With Sentry Diff
7092449 316.43 ms 352.15 ms 35.72 ms

App size

Revision Plain With Sentry Diff
7092449 0 B 0 B 0 B

The matrix jobs now actually update the version catalog. Remove Spring Boot versions that the current sample setup cannot build with the repository's Spring GraphQL integrations and Gradle version.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant