Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Jan 29, 2026

This PR adds a regular (non-unplugin) Rollup plugin which is also used for Vite.

This involved core changes:

  • Exporting more utilities from bundler-core
  • Adding globFiles core export for reusable asset finding
  • Rename generateGlobalInjectorCode to generateReleaseInjectorCode since that better describes what it does
  • Removing all the Rollup specific code from core

Rollup plugin changes:

  • Creating a new Rollup plugin that incorporates all the Rollup functionality
  • Moving the Rollup renderChunk tests from core to Rollup
  • Removed all the deps/references to unplugin

Note on test removal

This PR removes the disabled-sourcemaps-upload.test.ts‎ test, but all that did was check if a specific plugin was present.

I didn't re-add a test to check for upload because it's currently difficult to do with Jest and the logic is currently very clear:

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Rollup/Vite no longer uses unplugin by timfish in #858
  • Esbuild no longer uses unplugin by timfish in #871
  • Webpack no longer uses unplugin by timfish in #870

🤖 This preview updates automatically when you update the PR.

@timfish timfish force-pushed the timfish/feat/rollup-plugin-poc branch from a83a80e to 2c77a7d Compare February 9, 2026 18:58
@timfish timfish closed this Feb 9, 2026
@timfish timfish reopened this Feb 9, 2026
@timfish timfish changed the title PoC: Rollup Plugin without Unplugin feat: Rollup/Vite no longer use unplugin Feb 9, 2026
@timfish timfish marked this pull request as ready for review February 9, 2026 22:27
@timfish timfish requested review from Lms24 and chargome February 9, 2026 22:27
@timfish timfish changed the title feat: Rollup/Vite no longer use unplugin feat: Rollup/Vite no longer uses unplugin Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant