feat: Track major version for Vite and Rollup #867
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks! One request, otherwise LGTM.
There was a problem hiding this comment.
l: Can we also test Vite here? AFAICT, this only runs for rollup. Would be nice to have this covered but if it doesn't work easily, we can also leave it at rollup
There was a problem hiding this comment.
It's looking like Jest can't run Vite directly because... well Jest. Various ESM issues, etc.
What I really want to do is re-write these telemetry tests so we can override the DSN and capture the telemetry directly rather than this in-process hack (it was my hack 🤣). But this will have to wait until we can use Vitest.
There was a problem hiding this comment.
thanks for checking. Sounds reasonable to me!
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.9.0 | 4.9.1 | ## [v4.9.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#491) ##### New Features ✨ - Track major version for Vite and Rollup by [@timfish](https://github.com/timfish) in [#867](getsentry/sentry-javascript-bundler-plugins#867) ##### Internal Changes 🔧 - Bump craft for release workflow by [@chargome](https://github.com/chargome) in [#859](getsentry/sentry-javascript-bundler-plugins#859)
2 participants
#857 added tracking webpack major version usage and this PR extends that to track for Vite and Rollup too.