feat: webpack no longer uses unplugin #870
Open
+308
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
timfish
changed the title
chargome
approved these changes
Feb 11, 2026
Member
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Generally LGTM, just left one question. Feel free to merge if I misunderstood this.
| ); | ||
|
|
||
| void sentryBuildPluginManager | ||
| .createRelease() |
Member
There was a problem hiding this comment.
Don't we want to do this regardless of the sourcemapsEnabled check above?
Collaborator
Author
There was a problem hiding this comment.
More than likely yes? Seer picked this up on both the other PRs so I guess we should be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the webpack plugin to be a pure webpack plugin without using unplugin.