-
Notifications
You must be signed in to change notification settings - Fork 52
feat: esbuild no longer uses unplugin #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: esbuild no longer uses unplugin #871
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
🤖 This preview updates automatically when you update the PR. |
a2f60b7 to
8cafa7b
Compare
chargome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
packages/esbuild-plugin/src/index.ts
Outdated
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| export default sentryUnplugin.esbuild as (options?: Options) => any; | ||
|
|
||
| export default sentryEsbuildPlugin as (options?: Options) => EsbuildPlugin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this export a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes!
This PR removes unplugin as dependency for the esbuild plugin and instead just exports a regular esbuild plugin.