Skip to content

feat: Support V8 v14#32

Merged
timfish merged 7 commits intomainfrom
timfish/fix/v8-v14-issue
Apr 3, 2026
Merged

feat: Support V8 v14#32
timfish merged 7 commits intomainfrom
timfish/fix/v8-v14-issue

Conversation

@timfish
Copy link
Copy Markdown
Collaborator

@timfish timfish commented Apr 1, 2026

This PR adds support for V8 v14 by moving the json parsing from the native module into JavaScript. The previous solution was either causing build errors or runtime crashes depending on build config.

This PR also:

  • Updates node-abi to support newer Node.js versions
  • Ensures that if the binary is built from source due to no prebuilt match, it's copied to the expected location
  • Adds Node.js 25 to the test matrix which tests all of the above

Thanks to @nikitakot for supplying a thoroughly tested fix with a diff!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Support V8 v14 by timfish in #32

Bug Fixes 🐛

  • (security) Replace execSync with execFileSync to prevent command injection by fix-it-felix-sentry in #30

Internal Changes 🔧

Release

  • Fix changelog-preview permissions by BYK in #29
  • Bump Craft version to fix issues by BYK in #27
  • Switch from action-prepare-release to Craft by BYK in #25

Other

  • Enable Craft auto changelog by timfish in #33
  • Pin GitHub Actions to full-length commit SHAs by joshuarli in #31
  • Use pull_request_target for changelog preview by BYK in #28
  • macos-13 deprecation by timfish in #26

🤖 This preview updates automatically when you update the PR.

@timfish timfish changed the title fix: V8 v14 issue feat: Support V8 v14 Apr 2, 2026
@timfish timfish marked this pull request as ready for review April 2, 2026 19:26
@timfish timfish requested a review from Copilot April 2, 2026 19:27

This comment has been minimized.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@timfish timfish requested a review from logaretm April 3, 2026 12:44
@timfish timfish merged commit ad35117 into main Apr 3, 2026
130 of 132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible with Electron v38

3 participants