test(V7/browser-integration-tests): Check for sentry-trace header in TwP#11555
Merged
test(V7/browser-integration-tests): Check for sentry-trace header in TwP#11555
sentry-trace header in TwP#11555Conversation
Lms24
commented
Apr 11, 2024
Comment on lines
+8
to
+10
| integrations: [ | ||
| new Sentry.BrowserTracing({ tracingOrigins: ['http://example.com'], startTransactionOnPageLoad: false }), | ||
| ], |
Member
Author
There was a problem hiding this comment.
this test was broken before but still succeeded because our assertions didn't check anything specific other than ensuring that requests were made.
Lms24
changed the title
sentry-trace header in TwP
Contributor
size-limit report 📦
|
mydea
approved these changes
Apr 11, 2024
Member
Author
|
hmm why is size-check complaining? I guess we added more stuff in v7 recently and it just fluctuates a bit 🤔 |
Member
Author
|
FYI I'm gonna hold off from merging this in to avoid blocking today's v7 release (#11540) |
mydea
added a commit
that referenced
this pull request
Apr 11, 2024
This also forward-ports the tests from #11555, and adds some more tests.
mydea
added a commit
that referenced
this pull request
Apr 12, 2024
This also forward-ports the tests from #11555, and adds some more tests.
mydea
added a commit
that referenced
this pull request
Apr 15, 2024
This also forward-ports the tests from #11555, and adds some more tests. Node is a different story, will tackle it separately.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ry#11561) This also forward-ports the tests from getsentry#11555, and adds some more tests. Node is a different story, will tackle it separately.
This was referenced May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result of our investigation into tracing behaviour for fetch requests without active spans, this PR adjusts/adds tests around checking that a
sentry-traceheader is attached to outgoing requests in v7 of the SDK. As we also discovered today, this unfortunately doesn't work as "advertised in the basic TwP case:BrowserTracinginitialized;tracesSamplerateset:sentry-traceheader is attached without a sampled flag.BrowserTracingis initialized but notracesSampleRate: We currently don't attach asentry-traceheader although we should.