Skip to content

fix(node-core): Align pino mechanism type with spec conventions#19363

Open
logaretm wants to merge 2 commits intodevelopfrom
awad/fix-pino-mechanism-type
Open

fix(node-core): Align pino mechanism type with spec conventions#19363
logaretm wants to merge 2 commits intodevelopfrom
awad/fix-pino-mechanism-type

Conversation

@logaretm
Copy link
Member

In #18631 we noticed that Pino logs didn't match the mechanism types we are expecting, this PR addresses that.

Copilot AI review requested due to automatic review settings February 17, 2026 15:29
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,257 - 10,978 -16%
GET With Sentry 1,601 17% 1,820 -12%
GET With Sentry (error only) 5,794 63% 7,536 -23%
POST Baseline 1,164 - 1,133 +3%
POST With Sentry 558 48% 579 -4%
POST With Sentry (error only) 1,037 89% 996 +4%
MYSQL Baseline 3,215 - 3,903 -18%
MYSQL With Sentry 427 13% 482 -11%
MYSQL With Sentry (error only) 2,589 81% 3,143 -18%

View base workflow run

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Pino integration to align with Sentry's mechanism type conventions by changing the mechanism type from 'pino' to 'auto.log.pino'. This brings the Pino integration into consistency with other logging integrations in the codebase (Winston, Console, Consola), which all follow the 'auto.log.<logger>' naming pattern for mechanism types.

Changes:

  • Updated mechanism type in Pino integration from 'pino' to 'auto.log.pino'
  • Updated all test expectations to reflect the new mechanism type

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/node-core/src/integrations/pino.ts Changed mechanism type to follow the auto.log.* convention
dev-packages/node-integration-tests/suites/pino/test.ts Updated all test assertions to expect the new mechanism type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant