fix(node-core): Align pino mechanism type with spec conventions#19363
fix(node-core): Align pino mechanism type with spec conventions#19363
Conversation
Codecov Results 📊Generated by Codecov Action |
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Pino integration to align with Sentry's mechanism type conventions by changing the mechanism type from 'pino' to 'auto.log.pino'. This brings the Pino integration into consistency with other logging integrations in the codebase (Winston, Console, Consola), which all follow the 'auto.log.<logger>' naming pattern for mechanism types.
Changes:
- Updated mechanism type in Pino integration from
'pino'to'auto.log.pino' - Updated all test expectations to reflect the new mechanism type
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/node-core/src/integrations/pino.ts | Changed mechanism type to follow the auto.log.* convention |
| dev-packages/node-integration-tests/suites/pino/test.ts | Updated all test assertions to expect the new mechanism type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In #18631 we noticed that Pino logs didn't match the mechanism types we are expecting, this PR addresses that.