fix(nextjs): Normalize trailing slashes in App Router route parameterization#19365
Open
fix(nextjs): Normalize trailing slashes in App Router route parameterization#19365
Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
trailingSlash: trueis set innext.config.js, Next.js appends a trailing / to all URLs (e.g.,/aboutbecomes/about/).This caused
pageloadtransactions to be incorrectly named/:slug*(the catch-all route) for nearly all routes.Something to consider: This does not preserve the actual route visited, it normalizes by trimming the slashes for all routes, so if the user visits
/about/it will be reported as/aboutin traces. I noticed we have precedent for that with react-router so I followed that.Closes #19241