feat(feedback): Add setTheme() to dynamically update feedback widget color scheme#19430
Open
feat(feedback): Add setTheme() to dynamically update feedback widget color scheme#19430
setTheme() to dynamically update feedback widget color scheme#19430Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
ryan953
reviewed
Feb 19, 2026
| setTheme(colorScheme: 'light' | 'dark' | 'system'): void { | ||
| _options.colorScheme = colorScheme; | ||
| if (_shadow) { | ||
| const existingStyle = _shadow.querySelector('style'); |
Member
There was a problem hiding this comment.
careful with this! i think multiple styles can be added into the shadow root, base stuff for the button, and then more and more as the modal gets opened
edit: yeah checkout this: https://github.com/getsentry/sentry-javascript/blob/develop/packages/feedback/src/modal/integration.tsx#L39-L44 it's a 2nd <style> inserted
Member
Author
There was a problem hiding this comment.
Fixed by storing a direct reference to the main style element (_mainStyle) when it's created in _createShadow, instead of relying on querySelector('style'). Would this work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
setTheme(colorScheme: 'light' | 'dark' | 'system')method to the feedback integration, allowing applications to update the widget's color scheme at runtime without re-initializing the integration.closes #19257