Draft
Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
changed the title
Set the transaction name from the parameterized route on the isolation scope in the onError handler so error events include the correct transaction name (e.g. `GET /test-exception/:id`). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for request metadata on errors, POST body capture, parent-child spans, and trace propagation. Propagation tests for outgoing fetch are marked fixme due to Bun's native fetch not emitting undici diagnostics channels. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Capture errors with status >= 500 or <= 299 (unusual status in error handler). 3xx and 4xx are not captured by default. Adds unit tests for withElysia and an E2E test for the <= 299 case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add E2E test for thrown string errors (non-Error objects). Add fixme test documenting that isolation scopes leak between concurrent requests — setUser/setTag on the isolation scope is shared across requests since per-request scope forking is not yet implemented. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add onAfterHandle hook that sets sentry-trace and baggage response headers, enabling client-side trace continuation from server responses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logaretm
force-pushed
the
awad/js-1542-add-elysia-integration
branch
from
88a46a9 to
c6397a8
Compare
Replace Object.fromEntries(headers.entries()) with winterCGHeadersToDict which is compatible with all Headers implementations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Refine the logic to filter out empty spans generated for function handlers. This change ensures that spans without a name or attributes do not clutter transactions, while still allowing user-named spans to be displayed correctly.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Decisions:
@sentry/bunsince Elysia is Bun-first.bunServerIntegrationto avoid competing root spans, as Elysia creates its own.5xxand <=299, skips3xx/4xx. Aligned with Fastify. Overridable viashouldHandleError.spanEnd(still empty at that point) and strip them inbeforeSendEvent. Unless the user provides a named function, we will strip them, check the trace below as an example of a named functionlogRequestvs the stripped event handlers in other life cycle hooks.TODOs:
Closes #18956