ref(node): Stop using registerSpanErrorInstrumentation() on server#21169
Draft
mydea wants to merge 1 commit into
Draft
ref(node): Stop using registerSpanErrorInstrumentation() on server#21169mydea wants to merge 1 commit into
registerSpanErrorInstrumentation() on server#21169mydea wants to merge 1 commit into
Conversation
mydea
force-pushed
the
fn/remove-server-error-span
branch
from
53a9eb2 to
c0f6a9e
Compare
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this does nothing on node, because the implementation of this calls this under the hood:
basically browser-only, using
window.onerror. I believe this is handled specifically in node anyhow so should not be used/needed and allows us to streamline this a bit and potentially move this to a browser-only place eventually.