Skip to content

fix(cloudflare): Use original waitUntil to not create a deadlock#21197

Merged
JPeer264 merged 2 commits into
developfrom
jp/fix-waituntil-deadlock
May 28, 2026
Merged

fix(cloudflare): Use original waitUntil to not create a deadlock#21197
JPeer264 merged 2 commits into
developfrom
jp/fix-waituntil-deadlock

Conversation

@JPeer264
Copy link
Copy Markdown
Member

follow up to: #21156

This prevents a deadlock in the waitUntil, which happened in the sentry-mcp:

Screenshot 2026-05-27 at 17 04 19

@JPeer264 JPeer264 requested a review from a team May 27, 2026 15:04
@JPeer264 JPeer264 self-assigned this May 27, 2026
@JPeer264 JPeer264 requested a review from a team as a code owner May 27, 2026 15:04
@JPeer264 JPeer264 requested review from andreiborza, mydea and s1gr1d and removed request for a team May 27, 2026 15:04
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6da5af9. Configure here.

Comment thread packages/cloudflare/src/flush.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 27.16 kB - -
@sentry/browser - with treeshaking flags 25.61 kB - -
@sentry/browser (incl. Tracing) 45.23 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.47 kB - -
@sentry/browser (incl. Tracing, Profiling) 50.21 kB - -
@sentry/browser (incl. Tracing, Replay) 84.81 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 74.38 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 89.52 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.14 kB - -
@sentry/browser (incl. Feedback) 44.33 kB - -
@sentry/browser (incl. sendFeedback) 31.98 kB - -
@sentry/browser (incl. FeedbackAsync) 37.07 kB - -
@sentry/browser (incl. Metrics) 28.24 kB - -
@sentry/browser (incl. Logs) 28.48 kB - -
@sentry/browser (incl. Metrics & Logs) 29.18 kB - -
@sentry/react 28.99 kB - -
@sentry/react (incl. Tracing) 47.5 kB - -
@sentry/vue 32.2 kB - -
@sentry/vue (incl. Tracing) 47.15 kB - -
@sentry/svelte 27.18 kB - -
CDN Bundle 29.55 kB - -
CDN Bundle (incl. Tracing) 47.81 kB - -
CDN Bundle (incl. Logs, Metrics) 31.05 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.02 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.31 kB - -
CDN Bundle (incl. Tracing, Replay) 85.17 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.21 kB - -
CDN Bundle - uncompressed 87.56 kB - -
CDN Bundle (incl. Tracing) - uncompressed 144.03 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 92.04 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 147.78 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 216.77 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 262.8 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 266.55 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 276.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 280.24 kB - -
@sentry/nextjs (client) 50.01 kB - -
@sentry/sveltekit (client) 45.66 kB - -
@sentry/core/server 75.9 kB - -
@sentry/core/browser 63.06 kB - -
@sentry/node-core 61.69 kB -0.01% -2 B 🔽
@sentry/node 130.14 kB - -
@sentry/node - without tracing 74.11 kB - -
@sentry/aws-serverless 86.34 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 170.71 kB +0.08% +121 B 🔺
@sentry/cloudflare (withSentry) 427.26 kB +0.08% +310 B 🔺

View base workflow run

@JPeer264 JPeer264 merged commit 8a2a490 into develop May 28, 2026
265 of 266 checks passed
@JPeer264 JPeer264 deleted the jp/fix-waituntil-deadlock branch May 28, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants