fix: use a signal-safe address formatter#1444
Draft
supervacuus wants to merge 3 commits intomasterfrom
Draft
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended as an immediate fix to: getsentry/sentry-java#4830
However, it only fixes one instance of a signal-unsafe function used inside the
inprocbackend. Most issues with unsafe functions will probably not even find its way back to sentry because they just block the signal handler. So, while this fix might be enough to address the immediate problem in getsentry/sentry-java#4830 it also might only move the goalpost.I will create another PR that changes
inprocin way that splits the signal-handler in two parts:These PRs should be merged as either/or.