feat(attributes): add support for spanAttributes, which allows to capture values#4
feat(attributes): add support for spanAttributes, which allows to capture values#4Litarnus wants to merge 5 commits into
Conversation
| zend_string_release(lc_func); | ||
| } | ||
| } else { | ||
| instrumented_func = zend_hash_find_ptr(CG(function_table), lc_func); |
There was a problem hiding this comment.
Wrong function table for lookup
Medium Severity
Global spanAttributes rules are built only when instrument() resolves the target via CG(function_table), which is the current compilation unit’s table—not the request-wide registry. Registering instrumentation from another file (typical SDK bootstrap) leaves instrumented_func null, so rules are never stored while \Sentry\instrument still succeeds.
Reviewed by Cursor Bugbot for commit 825c271. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a7a4d8. Configure here.


Add support for the special attribute
spanAttributeswhich allows the extension to capture parameters and add them to the metadata array.For example: