fix(billing): Credits can apply to multiple SKUs#190
Open
brendanhsentry wants to merge 3 commits intomainfrom
Open
fix(billing): Credits can apply to multiple SKUs#190brendanhsentry wants to merge 3 commits intomainfrom
brendanhsentry wants to merge 3 commits intomainfrom
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
volokluev
reviewed
Mar 20, 2026
| CreditStatus status = 6; | ||
| // The SKUs this credit applies to. For shared budgets, the credit amount | ||
| // is shared across all listed SKUs. | ||
| repeated sentry_protos.billing.v1.SKU skus = 7; |
Member
There was a problem hiding this comment.
this would only make sense for dollar skus right? shared unit skus don't make any sense
Member
Author
There was a problem hiding this comment.
yes, that's true. are you thinking we should add a new message specifically for CreditBudget ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows Credits to be shared across multiple SKUs