-
-
Notifications
You must be signed in to change notification settings - Fork 358
chore: Move from using Hybrid SDK subspec to regular Sentry podspec #5451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com>
* fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com>
* fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 * Bump to 15.1 due to RN 0.81.0 requirements --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com>
|
Thank you for the heads up @itaybre and for keeping RN in sync 🙇 I'll test this out. |
iOS (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumped to 9.2.0
# Conflicts: # packages/core/RNSentry.podspec
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* chore(deps): v8: update Cocoa SDK to v9.1.1 * Bump to 9.2.0 * Bump to 9.3.0 * chore: Move from using Hybrid SDK subspec to regular Sentry podspec (#5451) * chore(deps): update Cocoa SDK to v9.0.0-alpha.0 * Adds changelog * fix: Fixes SentryScreenFrames use after being converted to Swift (#5153) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> * Move `sentry-cocoa` `enableLogs` out of experimental (#5267) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> * chore: Remove SentryFrameTracker imports (#5276) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * fix(podspec): Cocoa V9 allow any alpha version * chore(sample): Cocoa-v9: Bump MacOS sample to macos 12.0 (#5359) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 (#5369) * fix: Fixes SentryScreenFrames use after being converted to Swift * Fix build * Use non-experimental enableLogs * bump target * remove enable tracing * Update enableLogs tests * chore: Fix RNSentry after SentryFramesTracker conversion to swift * Run linter * Remove unused debug image provider imports * Remove imports * chore: Remove deprecated user property * chore: Remove use of deprecate integrations API (#5304) * Remove use of integrations in tests * chore: Remove use of deprecated prop (#5322) * ref: Move options to wrapper * chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9 * chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0 * Bump to 15.1 due to RN 0.81.0 requirements --------- Co-authored-by: Itay Brenner <itay.brenner@sentry.io> Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrasec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> * chore(ci): Cocoa V9: Run the full CI checks for cocoa-v9 (#5370) * Update changelog * Bumpt to RC1 * Remove cocoa-v9 from ci branches * fix: Use new session replay name for hybrid SDK * Fix rename * chore(lint): Fixes lint issues * Update changelog to GA * chore: Move from using Hybrid SDK subspec to regular Sentry podspec * Update changelog * Bump minimum to 9.1.0 * Replace SentryOptionsInternal with PrivateSentrySDKOnly helper method * Replace the deprecated `optionsWithDictionary` with `options(with:)` * Added RNSentry+formatters.h * Do not use subspec * Fix lint issues * Remove Unused import * Fix build issue * Add header search paths --------- Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io> * Adds changelog * Remove RNSentry+formatters.h copy --------- Co-authored-by: Itay Brenner <itaybrenner@hotmail.com> Co-authored-by: Denis Andrašec <denrase@gmail.com> Co-authored-by: Noah Martin <noahm444@gmail.com> Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
📢 Type of change
📜 Description
Replaced the HybridSDK subspec with the regular one.
💡 Motivation and Context
Simplify our maintenance work
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps