chore(e2e): Move replaysOnErrorSampleRate out of _experiments #5601

antonis · 2026-01-30T11:00:20Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

the replaysOnErrorSampleRate does no longer need to be under _experiments

💡 Motivation and Context

Just noticed that while debugging the flaky capture replay test

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2026-01-30T11:00:40Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

This PR will not appear in the changelog.

_{🤖 This preview updates automatically when you update the PR.}

github-actions · 2026-01-30T11:21:03Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	373.39 ms	432.76 ms	59.37 ms
Size	43.94 MiB	49.26 MiB	5.33 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`f3b058c`+dirty	422.90 ms	468.30 ms	45.40 ms
`294387d`+dirty	359.44 ms	393.40 ms	33.97 ms
`1d62dde`+dirty	366.59 ms	408.80 ms	42.21 ms
`d081295`+dirty	416.95 ms	461.24 ms	44.29 ms
`ad27f6e`+dirty	484.67 ms	532.79 ms	48.12 ms
`1226664`+dirty	377.65 ms	453.94 ms	76.29 ms
`083f560`+dirty	383.96 ms	417.76 ms	33.80 ms
`ec14be7`+dirty	401.58 ms	475.26 ms	73.68 ms
`eb07ba3`+dirty	419.49 ms	482.12 ms	62.63 ms
`d1fd647`+dirty	374.46 ms	409.51 ms	35.05 ms

App size

Revision	Plain	With Sentry	Diff
`f3b058c`+dirty	43.94 MiB	48.90 MiB	4.96 MiB
`294387d`+dirty	43.94 MiB	48.87 MiB	4.93 MiB
`1d62dde`+dirty	7.15 MiB	8.46 MiB	1.31 MiB
`d081295`+dirty	43.94 MiB	48.87 MiB	4.93 MiB
`ad27f6e`+dirty	43.94 MiB	48.90 MiB	4.96 MiB
`1226664`+dirty	7.15 MiB	8.46 MiB	1.30 MiB
`083f560`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`ec14be7`+dirty	7.15 MiB	8.42 MiB	1.26 MiB
`eb07ba3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`d1fd647`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

github-actions · 2026-01-30T11:26:02Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	419.90 ms	457.38 ms	37.48 ms
Size	43.75 MiB	48.41 MiB	4.65 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`f3b058c`+dirty	501.18 ms	536.70 ms	35.52 ms
`bfe454a`+dirty	573.44 ms	579.46 ms	6.02 ms
`294387d`+dirty	424.30 ms	465.40 ms	41.10 ms
`955f2eb`+dirty	422.74 ms	410.19 ms	-12.55 ms
`3bd3f0d`+dirty	447.21 ms	472.31 ms	25.10 ms
`d081295`+dirty	408.08 ms	453.62 ms	45.54 ms
`ad27f6e`+dirty	471.44 ms	516.23 ms	44.79 ms
`07808fb`+dirty	419.10 ms	419.08 ms	-0.02 ms
`170d5ea`+dirty	407.92 ms	422.49 ms	14.57 ms
`8e653ac`+dirty	360.28 ms	372.04 ms	11.76 ms

App size

Revision	Plain	With Sentry	Diff
`f3b058c`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`bfe454a`+dirty	17.75 MiB	19.69 MiB	1.94 MiB
`294387d`+dirty	43.75 MiB	48.04 MiB	4.29 MiB
`955f2eb`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`3bd3f0d`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`d081295`+dirty	43.75 MiB	48.04 MiB	4.29 MiB
`ad27f6e`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`07808fb`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`170d5ea`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`8e653ac`+dirty	17.75 MiB	19.75 MiB	2.00 MiB

github-actions · 2026-01-30T11:26:48Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1186.69 ms	1185.91 ms	-0.78 ms
Size	3.38 MiB	4.60 MiB	1.22 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6bd9054`+dirty	1207.02 ms	1199.27 ms	-7.76 ms
`d73150f`+dirty	1224.52 ms	1227.17 ms	2.65 ms
`d081295`+dirty	1205.24 ms	1207.52 ms	2.28 ms
`d1fd647`+dirty	1218.16 ms	1225.82 ms	7.65 ms
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`955f2eb`+dirty	1225.78 ms	1239.27 ms	13.49 ms
`5ee3314`+dirty	1234.25 ms	1235.44 ms	1.19 ms
`70250df`+dirty	1211.96 ms	1222.31 ms	10.35 ms
`664c66f`+dirty	1195.94 ms	1194.80 ms	-1.14 ms

App size

Revision	Plain	With Sentry	Diff
`6bd9054`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`d73150f`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d081295`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`d1fd647`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`955f2eb`+dirty	3.19 MiB	4.55 MiB	1.36 MiB
`5ee3314`+dirty	3.19 MiB	4.55 MiB	1.37 MiB
`70250df`+dirty	3.44 MiB	4.59 MiB	1.15 MiB
`664c66f`+dirty	3.38 MiB	4.60 MiB	1.22 MiB

github-actions · 2026-01-30T11:34:37Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1206.81 ms	1212.98 ms	6.17 ms
Size	3.38 MiB	4.60 MiB	1.22 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`6bd9054`+dirty	1212.20 ms	1217.89 ms	5.70 ms
`d73150f`+dirty	1198.44 ms	1210.06 ms	11.62 ms
`d081295`+dirty	1214.40 ms	1211.27 ms	-3.13 ms
`d1fd647`+dirty	1219.35 ms	1233.18 ms	13.83 ms
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`955f2eb`+dirty	1235.06 ms	1253.88 ms	18.81 ms
`5ee3314`+dirty	1215.18 ms	1207.64 ms	-7.54 ms
`70250df`+dirty	1214.51 ms	1215.04 ms	0.53 ms
`664c66f`+dirty	1215.37 ms	1221.30 ms	5.92 ms

App size

Revision	Plain	With Sentry	Diff
`6bd9054`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`d73150f`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d081295`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`d1fd647`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`955f2eb`+dirty	2.63 MiB	3.98 MiB	1.35 MiB
`5ee3314`+dirty	2.63 MiB	3.99 MiB	1.35 MiB
`70250df`+dirty	3.44 MiB	4.59 MiB	1.15 MiB
`664c66f`+dirty	3.38 MiB	4.60 MiB	1.22 MiB

The E2E test was looking for replay_id in event._dsc.replay_id, but the Sentry API may not include _dsc in the event JSON response. The SDK correctly adds replay_id to event.contexts.replay.replay_id. Changes: - Update sentryApi.js to check event.contexts.replay.replay_id first - Fallback to event._dsc.replay_id for backwards compatibility - Add clear error message if replay_id not found in either location - Add type conversion for LaunchArguments.replaysOnErrorSampleRate to ensure it's always a number (LaunchArguments may return strings) This fixes the iOS E2E test failure that started on Jan 28, 2026 after JS SDK bump to 10.37.0. The issue was not with the SDK (replays work correctly), but with how the test verifies replay attachment. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

dev-packages/e2e-tests/patch-scripts/rn.patch.app.js

This reverts commit 604d202.

lucas-zimerman

LGMT!

test(e2e): Fix capture replay E2E test failure

765bf95

antonis added the ready-to-merge Triggers the full CI test suite label Jan 30, 2026

antonis commented Jan 30, 2026

View reviewed changes

dev-packages/e2e-tests/patch-scripts/rn.patch.app.js Show resolved Hide resolved

antonis added 5 commits February 3, 2026 13:29

Merge branch 'main' into antonis/e2e-captureReplay

511dea4

Reverse test code

a5b16bd

Log errors

604d202

Revert "Log errors"

bc0e3d8

This reverts commit 604d202.

Merge branch 'main' into antonis/e2e-captureReplay

90d57e5

antonis changed the title ~~test(e2e): Fix capture replay E2E test failure~~ chore(e2e): Move replaysOnErrorSampleRate out of _experiments Feb 3, 2026

antonis marked this pull request as ready for review February 3, 2026 13:43

antonis requested review from alwx and lucas-zimerman as code owners February 3, 2026 13:43

lucas-zimerman approved these changes Feb 3, 2026

View reviewed changes

antonis merged commit 9ced351 into main Feb 4, 2026
145 of 152 checks passed

antonis deleted the antonis/e2e-captureReplay branch February 4, 2026 08:31

Uh oh!

chore(e2e): Move replaysOnErrorSampleRate out of _experiments #5601

chore(e2e): Move replaysOnErrorSampleRate out of _experiments #5601

Uh oh!

Conversation

antonis commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Jan 30, 2026 •

edited

Loading

github-actions bot commented Jan 30, 2026 •

edited

Loading

github-actions bot commented Jan 30, 2026 •

edited

Loading

github-actions bot commented Jan 30, 2026 •

edited

Loading

github-actions bot commented Jan 30, 2026 •

edited

Loading

github-actions bot commented Jan 30, 2026 •

edited

Loading