-
-
Notifications
You must be signed in to change notification settings - Fork 358
iOS UI Profiling #5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
iOS UI Profiling #5611
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -294,16 +294,26 @@ export interface BaseReactNativeOptions { | |
| */ | ||
| enableUnhandledCPPExceptionsV2?: boolean; | ||
|
|
||
| /** | ||
| * Configuration options for UI profiling. | ||
| * It supports two modes: `manual` and `trace`. | ||
| * - In `trace` mode, the profiler runs based on active sampled spans. | ||
| * - In `manual` mode, profiling is controlled via start/stop API calls. | ||
| * | ||
| * @experimental | ||
| */ | ||
| profilingOptions?: ProfilingOptions; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we keep androidProfilingOptions and mark it as deprecated?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| /** | ||
| * Configuration options for Android UI profiling. | ||
| * UI profiling supports two modes: `manual` and `trace`. | ||
| * It supports two modes: `manual` and `trace`. | ||
| * - In `trace` mode, the profiler runs based on active sampled spans. | ||
| * - In `manual` mode, profiling is controlled via start/stop API calls. | ||
| * | ||
| * @experimental | ||
| * @platform android | ||
| * @deprecated Use `profilingOptions` instead. This option will be removed in the next major version. | ||
| */ | ||
| androidProfilingOptions?: AndroidProfilingOptions; | ||
| androidProfilingOptions?: ProfilingOptions; | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -342,19 +352,18 @@ export interface BaseReactNativeOptions { | |
| export type SentryReplayQuality = 'low' | 'medium' | 'high'; | ||
|
|
||
| /** | ||
| * Android UI profiling lifecycle modes. | ||
| * UI profiling lifecycle modes. | ||
| * - `trace`: Profiler runs based on active sampled spans | ||
| * - `manual`: Profiler is controlled manually via start/stop API calls | ||
| */ | ||
| export type AndroidProfilingLifecycle = 'trace' | 'manual'; | ||
| export type ProfilingLifecycle = 'trace' | 'manual'; | ||
|
|
||
| /** | ||
| * Configuration options for Android UI profiling. | ||
| * Configuration options for UI profiling. | ||
| * | ||
| * @experimental | ||
| * @platform android | ||
| */ | ||
| export interface AndroidProfilingOptions { | ||
| export interface ProfilingOptions { | ||
| /** | ||
| * Sample rate for profiling sessions. | ||
| * This is evaluated once per session and determines if profiling should be enabled for that session. | ||
|
|
@@ -369,9 +378,9 @@ export interface AndroidProfilingOptions { | |
| * - `trace`: Profiler runs while there is at least one active sampled span | ||
| * - `manual`: Profiler is controlled manually via Sentry.profiler.startProfiler/stopProfiler | ||
| * | ||
| * @default 'trace' | ||
| * @default 'manual' | ||
| */ | ||
| lifecycle?: AndroidProfilingLifecycle; | ||
| lifecycle?: ProfilingLifecycle; | ||
|
|
||
| /** | ||
| * Enable profiling on app start. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we decide to proceed with just renaming the
androidProfilingOptionstoprofilingOptionsin the conversation above let's add a note to the changelog