Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your Pull Request 🎉
Please keep these instructions in mind so we can review it more efficiently:
feat:,fix:,ref:,meta:)Other Notes
Description
Describe your changes:
This introduces a custom Sentry integration for the concurrent-ruby library, ensuring proper hub and span propagation across background threads created by Concurrent::Promises.future and Concurrent::Promises::Promise.
Key changes:
Added a Sentry::ConcurrentRuby module that patches:
Concurrent::Promises.future
Concurrent::Promises::Future#on_resolution
Automatically propagates the current Sentry hub and active span to background threads.
Wraps each future/promise execution inside Sentry.with_child_span, creating a child span for async tasks.
Sets the child span as the current span for that thread to preserve the correct trace hierarchy.
Removes the need for manually calling Sentry.with_child_span inside individual futures.
Result: