feat: app hang capture on desktop#2709
Conversation
|
macOS0c0c4df to
7355756
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7355756. Configure here.
JoshuaMoelans
left a comment
There was a problem hiding this comment.
A few comments, but looks good overall! Only softly blocking on the stubs & fixing the changelog :)
In https://github.com/getsentry/sentry-unity/blob/feat/native-app-hang/src/Sentry.Unity.iOS/SentryNativeCocoa.cs#L45-L51 we disable the AnrIntegration if EnableAppHangTracking is true; should we do the same for macOS (it is currently gated behind platform == RuntimePlatform.IPhonePlayer
Do we need stubs for the new sentry_options_set_enable_app_hang_tracking, sentry_options_set_app_hang_timeout, and sentry_app_hang_heartbeat in https://github.com/getsentry/sentry-unity/blob/feat/native-app-hang/package-dev/Plugins/Switch/sentry_native_stubs.c ?
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
…entry-unity into feat/native-app-hang
Co-authored-by: JoshuaMoelans <60878493+JoshuaMoelans@users.noreply.github.com>
When targeting macOS and using Cocoa, then there is no ANR support other than the C# |
Great catch! Totally missed that. Thanks! |
JoshuaMoelans
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all the comments 🫶

With getsentry/sentry-native#1806
sentry-nativegained the ability to capture app hangs in-proc for macOS, Linux, and Windows.The options controlling this feature got added as
experimentaland default tofalseright now.Added the app hang capture to our e2e testing suite.