Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Dec 18, 2025

The ColorOrAlias type is problematic since it creates a coupling between how the theme is structured and which colors are available. Along the same lines, organizing our theme with a flat key list isn't a scalable long term approach.

Developers should use variants to encapsulate different color meanings or access colors directly on the theme.

Co-authored-by: jonas.badalic <jonas.badalic@sentry.io>
@cursor
Copy link
Contributor

cursor bot commented Dec 18, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 18, 2025
@JonasBa JonasBa marked this pull request as ready for review December 18, 2025 22:53
@JonasBa JonasBa requested a review from a team as a code owner December 18, 2025 22:53
aliases: Aliases
) => ({
tooltipUnderline: (underlineColor: ColorOrAlias = 'gray300') => ({
tooltipUnderline: (underlineColor: ColorOrAlias | string = 'gray300') => ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasBa there’s only a handful of usages that use tooltipUnderline with a specific color, and it’s only:

  • linkUnderline
  • gray200
  • background
  • success
  • successText, warningText, errorText
  • green300, red300, gray300

I think we should be able to find token replacements for those and just use our color tokens here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc there was another component that was using this, so I wanted to keep the changes small, but let me see if we can indeed one shot this

@getsantry
Copy link
Contributor

getsantry bot commented Jan 10, 2026

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants