Skip to content

feat(view-hierarchy): Allow forcing absolute positioning#107507

Merged
Lms24 merged 2 commits intogetsentry:masterfrom
timfish:timfish/feat/view-hierarchy-absolute
Feb 9, 2026
Merged

feat(view-hierarchy): Allow forcing absolute positioning#107507
Lms24 merged 2 commits intogetsentry:masterfrom
timfish:timfish/feat/view-hierarchy-absolute

Conversation

@timfish
Copy link
Copy Markdown
Contributor

@timfish timfish commented Feb 3, 2026

Currently relative/absolute positioning for View Hierarchy wireframes is always relative unless the platform matches a predefined list:

getHierarchyDimensions(
hierarchy,
['flutter', 'dart-flutter'].includes(platform ?? '')
),

This PR allows overriding the platform defaults via the root positioning property in the hierarchy data.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 3, 2026
@timfish
Copy link
Copy Markdown
Contributor Author

timfish commented Feb 5, 2026

I think the CI failures are related to permissions because this is on my fork. Let me know if you want me to push this to the Sentry repo (if I have permissions!).

@timfish timfish marked this pull request as ready for review February 5, 2026 15:01
@timfish timfish requested a review from a team as a code owner February 5, 2026 15:01
Comment thread static/app/components/events/viewHierarchy/wireframe.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread static/app/components/events/viewHierarchy/wireframe.tsx Outdated
@Lms24 Lms24 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Feb 5, 2026
@Lms24 Lms24 merged commit 1d1ca3b into getsentry:master Feb 9, 2026
59 of 60 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants