chore(ACI): Remove all references of sentry_app_identifier#107991
Merged
chore(ACI): Remove all references of sentry_app_identifier#107991
Conversation
github-actions
Bot
added
the
Scope: Backend
ceorourke
force-pushed
the
ceorourke/ISWF-2035
branch
from
0f88333 to
3eb48f2
Compare
…p_id" This reverts commit 5ceb8ea.
ceorourke
force-pushed
the
ceorourke/ISWF-2035
branch
from
7726201 to
3cf1fae
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
kcons
reviewed
Feb 18, 2026
Member
kcons
left a comment
kcons
left a comment
There was a problem hiding this comment.
With the caveat that I'm still a bit of a novice in outboxes, sentry apps, and realistically notifications, this looks ok to me aside from the schema validation concern.
| }, | ||
| }, | ||
| "required": ["target_type", "target_identifier"], | ||
| "additionalProperties": False, |
Member
There was a problem hiding this comment.
Does this need to be True, as prior to migration we expect sentry_app_identifier to be present in data but not the schema?
Member
Author
There was a problem hiding this comment.
Good catch, I put back the sentry_app_identifier in a test and re-ran it to confirm 👍 Changing this to True for now.
GabeVillalobos
approved these changes
Feb 19, 2026
JonasBa
pushed a commit
that referenced
this pull request
Feb 19, 2026
1 task
mchen-sentry
pushed a commit
that referenced
this pull request
Feb 24, 2026
ceorourke
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #107887 and #107982 to fully remove all references of
sentry_app_identifierto prepare for running a migration to remove it from the database.