Skip to content

ref(o11y): Add set_attribute calls in span consumers#117639

Open
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/data-browsing-streaming-platform/set-attribute
Open

ref(o11y): Add set_attribute calls in span consumers#117639
alexander-alderman-webb wants to merge 2 commits into
masterfrom
webb/data-browsing-streaming-platform/set-attribute

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Supplement existing set_tag/set_context/set_extra calls with set_attribute so that data gets added to attributes-based telemetry as well. This will make the migration to span streaming easier.

Related to getsentry/sentry-python#6537

@alexander-alderman-webb alexander-alderman-webb requested review from a team as code owners June 15, 2026 06:57
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 15, 2026
Comment thread src/sentry/spans/consumers/process/factory.py

@untitaker untitaker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does the user need both? that doesn't seem like good UX for our customers either.

see also getsentry/sentry-rust#1083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants