fix(integrations): Catch decoding errors in MS Teams install serializer#117666
Open
sentry[bot] wants to merge 1 commit into
Open
fix(integrations): Catch decoding errors in MS Teams install serializer#117666sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MsTeamsInstallSerializer.validate()method was not robust enough to handle malformedsigned_paramsinput. Specifically, theunsign()utility function, which performsurlsafe_b64decode().decode(), could raiseUnicodeDecodeErrororbinascii.Errorif the input was not valid base64 or not valid UTF-8 after decoding. These exceptions were not caught, leading to an uncaught 500 Internal Server Error instead of a user-friendly 400 Bad Request with a validation message.This change updates the
validate()method to catchUnicodeDecodeErrorandbinascii.ErroralongsideBadSignature. When these exceptions occur, aserializers.ValidationError("Invalid installation link")is raised, providing a consistent and expected error response for invalid input.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5QMK