feat(gcpkms): add SOPS_GCP_KMS_ENDPOINT and SOPS_GCP_KMS_UNIVERSE_DOMAIN env vars#2114
Open
DnR-iData wants to merge 4 commits intogetsops:mainfrom
Open
feat(gcpkms): add SOPS_GCP_KMS_ENDPOINT and SOPS_GCP_KMS_UNIVERSE_DOMAIN env vars#2114DnR-iData wants to merge 4 commits intogetsops:mainfrom
DnR-iData wants to merge 4 commits intogetsops:mainfrom
Conversation
…AIN env vars Allow overriding the GCP KMS endpoint and universe domain via environment variables. This enables use of sovereign cloud environments that expose a GCP-compatible KMS API at a non-standard endpoint (e.g. S3NS/Thales TPC with cloudkms.s3nsapis.fr). Signed-off-by: David RIBEIRO <dr@devops.works>
DnR-iData
force-pushed
the
feat/gcpkms-sovereign-cloud-endpoint
branch
from
bb5e250 to
fc89e01
Compare
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
- Use else if to make SOPS_GCP_KMS_ENDPOINT precedence over SOPS_GCP_KMS_UNIVERSE_DOMAIN explicit in code - Use RST note directive in README.rst - Verify env var options are applied by asserting on client.Connection().Target() in tests Signed-off-by: David RIBEIRO <dr@devops.works>
felixfontein
approved these changes
Mar 31, 2026
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding the GCP KMS endpoint and universe domain via environment
variables, using two new env vars:
SOPS_GCP_KMS_ENDPOINT: overrides the KMS endpoint URL directlySOPS_GCP_KMS_UNIVERSE_DOMAIN: derives the endpoint ascloudkms.<domain>:443This enables use of sovereign cloud environments that expose a
GCP-compatible KMS API at a non-standard endpoint (e.g. S3NS/Thales TPC
with
cloudkms.s3nsapis.fr).Both the gRPC and REST client paths are supported. Documentation updated
in README.rst.