server: support image+text input for embeddings (Qwen3-VL-Embedding)#18665
Closed
ngxson wants to merge 1 commit intoggml-org:masterfrom
Closed
server: support image+text input for embeddings (Qwen3-VL-Embedding)#18665ngxson wants to merge 1 commit intoggml-org:masterfrom
ngxson wants to merge 1 commit intoggml-org:masterfrom
Conversation
Member
|
When you convert the model, try to add llama.cpp/convert_hf_to_gguf.py Lines 10974 to 10981 in 294b2b4 |
Member
|
IIRC they forgot to add |
Contributor
Author
|
Oh sorry I didn't notice that it's private 😅 temporary closing this to keep it under the radar |
|
I've fixed the Qwen3-VL-Embedding issues in llama.cpp and verified the fix with regression tests. Check out the code here: https://github.com/Tokimorphling/qwen3-vl-embedding The implementation of the Qwen3-VL series in llama.cpp seems to be problematic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target support: https://huggingface.co/Qwen/Qwen3-VL-Embedding-2B
Important
the original Qwen3-VL-Embedding model is missing 1_Pooling, I don't think it's actually ready to be used unless Qwen team fixed it (I already reached out to them, but got no responses)
But currently, the model is missing
1_Pooling, so it cannot be correctly converted to GGUFThis PR aims to support mixed text+image (and maybe audio input for models supporting it) using OAI-compat
content-like schema:{ "input": [ { "type": "text", "text": "mixed text and image input" }, { "type": "image", "image_url": { "url": "https://huggingface.co/ggml-org/tinygemma3-GGUF/resolve/main/test/11_truck.png" } } ] }