fix(cuda): sanitize invalid Blackwell smpbo values#23766
Draft
peter941221 wants to merge 1 commit into
Draft
Conversation
|
Hi @peter941221, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23385.
Failure mechanism:
cudaDeviceProp.sharedMemPerBlockOptinvalues such as0or0x100000001ggml_cuda_init()stored that value directly ininfo.devices[id].smpbosmpboas a hard shared-memory ceiling, not just softmaxmmq.cuhuses it to prune valid MMQ tile shapes, which can leavemmq_x_best = 0and abort on Blackwellmmid.cuandsoftmax.cualso use the same cached limit when setting dynamic shared memory attributesSemantic change:
sharedMemPerBlockOptinonce during CUDA device-info initialization0or implausibly large (> 1 MiB), log a warning and fall back tosharedMemPerBlocksmpboconsumer gets the same sane valueWhy here instead of another per-kernel workaround:
Validation:
ggml/src/ggml-cuda/ggml-cuda.cuinitializesinfo.devices[id].smpboggml/src/ggml-cuda/mmq.cuhgates MMQ tile selection onsmpboggml/src/ggml-cuda/mmid.cuandggml/src/ggml-cuda/softmax.cualso consumesmpbo-DGGML_CUDA=ON -DCMAKE_CUDA_ARCHITECTURES=120