common: fix HTTPS handshake on Windows, harden HTTP client#23787
common: fix HTTPS handshake on Windows, harden HTTP client#23787ServeurpersoCom wants to merge 1 commit into
Conversation
The -hf downloader hung or failed on Windows builds using from-source LibreSSL. Root cause: MSVC at /O2 miscompiles LibreSSL's bignum on Windows x64, producing non deterministic RSA verification during the TLS handshake (ssl_err 0x4FFF086, alternating first/last octet invalid). Verified clean on Linux with the same sources. BoringSSL under MSVC was not affected.
|
I'm also checking the other codepath, the build with Wine from llama-install.sh, in any case this PR is atomic and fixes 3 HTTP client problems (timeout + verbosity + MSVC RSA build) |
|
Im trying with but still stuck: |
Did you try it with this PR merged and the freeze remains silent? |
Im double checking everything rn (windows testing requires many steps haha), but i have the good commit: |
Reproduced: slilent freeze!! I fix also this codepath. |
|
llama-install.sh: BoringSSL requires fixes on their own repo to build on Wine. I'm switching to LibreSSL. |

Overview
The -hf downloader hung or failed on Windows builds using from-source LibreSSL. Root cause: MSVC at /O2 miscompiles LibreSSL's bignum on Windows x64, producing non deterministic RSA verification during the TLS handshake (ssl_err 0x4FFF086, alternating first/last octet invalid). Verified clean on Linux with the same sources. BoringSSL under MSVC was not affected.
Fix this:
Add a timeout and surface the log:
Then finally, correct the root cause:
Requirements