mtmd: fix gemma 4 projector pre_norm#23822
Merged
Merged
Conversation
CISC
approved these changes
May 28, 2026
Contributor
Author
|
asking for 2nd approval @ggml-org/maintainers 🙏 |
ServeurpersoCom
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The early pre-release version of gemma 4 uses post norm for multimodal projector, but it was later swapped to pre-norm and I did not notice about that.
This should fix some vision-related problems with gemma 4.
Ref python code: https://github.com/huggingface/transformers/blob/1656d90b774d94c30af24113e60e926fc2f39072/src/transformers/models/gemma4/modeling_gemma4.py#L2068-L2092
Test:
Requirements