Skip to content

fix(a11y): Tabbing on header columns should work with Frozen Grid#2423

Merged
ghiscoding merged 2 commits intomasterfrom
bugfix/frozen-grid-header-tabbing
Mar 5, 2026
Merged

fix(a11y): Tabbing on header columns should work with Frozen Grid#2423
ghiscoding merged 2 commits intomasterfrom
bugfix/frozen-grid-header-tabbing

Conversation

@ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 5, 2026

follow-up of #2421 which fixed the Filter elements tabbing, but then I found that I also had issues with the column headers too, the updated code will detect if we're in the column titles bar or if we're in the header filters bar and then use similar code as in #2421 but just using different query selector.

Mainly fixes these issues:

  • Frozen Grid that is wider than viewport has column misalignment issues
  • Frozen Grid tabbing from header title requires 2x tab to reach the header on the right side of the viewport

column misalignments

below is what previously happened if we were using frozen columns and our column were wider than viewport and we scrolled to the right, after Tabbing the columns became misaligned.

image

with fixes

below is an animated gif of all frozen grid fixes applied for columns misalignements and also for Column Titles row and also for Column Filters row.

brave_FWh7pR06mt

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (42279ae) to head (4385612).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2423   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         196      196           
  Lines       24314    24318    +4     
  Branches     8518     8518           
=======================================
+ Hits        24314    24318    +4     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2423

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2423

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2423

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2423

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2423

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2423

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2423

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2423

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2423

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2423

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2423

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2423

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2423

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2423

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2423

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2423

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2423

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2423

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2423

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2423

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2423

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2423

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2423

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2423

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2423

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2423

commit: c93eafc

@ghiscoding ghiscoding merged commit 9d624c5 into master Mar 5, 2026
12 checks passed
@ghiscoding ghiscoding deleted the bugfix/frozen-grid-header-tabbing branch March 5, 2026 04:45
@github-actions
Copy link

github-actions bot commented Mar 7, 2026

🎉 This pull request is included in version 10.1.0 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant