fix(a11y): Tabbing on header columns should work with Frozen Grid#2423
Merged
ghiscoding merged 2 commits intomasterfrom Mar 5, 2026
Merged
fix(a11y): Tabbing on header columns should work with Frozen Grid#2423ghiscoding merged 2 commits intomasterfrom
ghiscoding merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2423 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 196 196
Lines 24314 24318 +4
Branches 8518 8518
=======================================
+ Hits 24314 24318 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
|
🎉 This pull request is included in version 10.1.0 📦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up of #2421 which fixed the Filter elements tabbing, but then I found that I also had issues with the column headers too, the updated code will detect if we're in the column titles bar or if we're in the header filters bar and then use similar code as in #2421 but just using different query selector.
Mainly fixes these issues:
column misalignments
below is what previously happened if we were using frozen columns and our column were wider than viewport and we scrolled to the right, after Tabbing the columns became misaligned.
with fixes
below is an animated gif of all frozen grid fixes applied for columns misalignements and also for Column Titles row and also for Column Filters row.