Skip to content

Fix E2E testing race condition in progress syncing #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jovnc merged 3 commits into from
Apr 1, 2026
Merged

Fix E2E testing race condition in progress syncing #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ee3d41
add separate PAT to mitigate race condition during e2e
SAN-MUYUN Mar 29, 2026
5e239bb
improve code readability
SAN-MUYUN Mar 29, 2026
0720532
update GH_TOKEN setting and validation steps
SAN-MUYUN Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,24 @@ jobs:
python-version: ["3.13"]

steps:
- name: Validate GH_PAT secret
- name: Set GH_TOKEN
shell: bash
env:
GH_PAT: ${{ secrets.GH_PAT }}
GH_PAT: >-
Comment thread
jovnc marked this conversation as resolved.
${{
matrix.os == 'ubuntu-latest' &&
secrets.GH_PAT_UBUNTU ||
(matrix.os != 'ubuntu-latest' && secrets.GH_PAT) ||
Comment thread
jovnc marked this conversation as resolved.
''
}}
run: |
if [ -z "$GH_PAT" ]; then
echo "GH_PAT secret is required to run E2E tests."
echo "GH_TOKEN=$GH_PAT" >> $GITHUB_ENV
Comment thread
jovnc marked this conversation as resolved.

- name: Validate GH_TOKEN
shell: bash
run: |
if [ -z "$GH_TOKEN" ]; then
echo "Required PAT secret is missing for ${{ matrix.os }}."
exit 1
fi

Expand Down Expand Up @@ -67,7 +78,5 @@ jobs:
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- name: Run E2E tests
env:
GH_TOKEN: ${{ secrets.GH_PAT }}
run: |
uv run pytest tests/e2e/ -v
21 changes: 15 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,24 @@ jobs:
python-version: ["3.13"]

steps:
- name: Validate GH_PAT secret
- name: Set GH_TOKEN
shell: bash
env:
GH_PAT: ${{ secrets.GH_PAT }}
GH_PAT: >-
${{
matrix.os == 'ubuntu-latest' &&
secrets.GH_PAT_UBUNTU ||
(matrix.os != 'ubuntu-latest' && secrets.GH_PAT) ||
Comment thread
jovnc marked this conversation as resolved.
''
}}
run: |
if [ -z "$GH_PAT" ]; then
echo "GH_PAT secret is required to run E2E tests."
echo "GH_TOKEN=$GH_PAT" >> $GITHUB_ENV

- name: Validate GH_TOKEN
shell: bash
run: |
if [ -z "$GH_TOKEN" ]; then
echo "Required PAT secret is missing for ${{ matrix.os }}."
exit 1
fi
Comment thread
jovnc marked this conversation as resolved.

Expand Down Expand Up @@ -61,7 +72,5 @@ jobs:
git config --global user.email "github-actions[bot]@users.noreply.github.com"

- name: Run E2E tests
env:
GH_TOKEN: ${{ secrets.GH_PAT }}
run: |
uv run pytest tests/e2e/ -v
Loading