Merged
Conversation
218 sinks across 46 tool defs covering the framework-specific dangerous
methods on top of the language stdlib sinks. Web frameworks contribute
their XSS bypasses (html_safe, mark_safe, dangerouslySetInnerHTML,
v-html, {!! !!}, th:utext), template injection points (render inline:,
render_template_string), redirect helpers, and file send paths. ORMs
contribute their raw query escape hatches (find_by_sql, $queryRawUnsafe,
text(), Sequel.lit, db.Raw) and mass assignment surfaces.
Notes capture when only some forms are dangerous: order() because column
names aren't parameterizable, $queryRaw safe as tagged template but not
with concat, where() safe with hash but not with interpolated string.
The fullstack metaframeworks (Next, Nuxt, Remix) carry both their
client-side dangerouslySetInnerHTML and their server-side redirect
sinks. Mongoose gets nosql_injection for $where and operator injection
through unfiltered query objects. Spring gets the SpEL parser sink that
log4shell-style attacks run through.
Updated TestSinksRubyProject to index by tool+symbol since Ruby,
Rails, and ActiveRecord all have a Marshal.load now.
Closes #16
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
218 sinks across 46 tool defs (28 web frameworks, 17 ORMs/query builders) covering the framework-specific dangerous methods on top of the language stdlib sinks from #24.
Web frameworks contribute their XSS bypasses (
html_safe,mark_safe,dangerouslySetInnerHTML,v-html,{!! !!},th:utext,{@html}), template injection points (render inline:,render_template_string,Blade::render), redirect helpers, and file send paths. ORMs contribute raw query escape hatches (find_by_sql,$queryRawUnsafe,text(),Sequel.lit,Arel.sql,db.Raw) and mass assignment surfaces.Notes capture when only some forms are dangerous:
order()because column names aren't parameterizable,$queryRawsafe as tagged template but not with concat,where()safe with hash but not with interpolated string. The fullstack metaframeworks (Next, Nuxt, Remix, SvelteKit) carry both client-sidedangerouslySetInnerHTMLand server-side redirect sinks. Mongoose getsnosql_injectionfor$whereand operator injection through unfiltered query objects. Spring gets the SpEL parser sink that expression-injection attacks run through.Sources: Brakeman check definitions, Bandit blacklists, gosec rules, Semgrep registry rulesets per framework.
brief sinkson the Rails fixture now shows 74 sinks across Ruby, Rails, and ActiveRecord.Closes #16