Conversation
…SSRF from backend mapping Stack now only includes tools that actually fire a threat mapping or carry sinks, trimming infrastructure tools (Bundler, Docker, CI, linters) that have taxonomy but no security relevance. ecosystem-dashboard goes from 16 stack entries to 7. Empty threat-model output now shows the detected ecosystems and stack before saying "No threat categories match the detected stack" instead of the misleading "No security data available for detected tools" which implied brief had no data about the stack. Removed SSRF from the role:framework + layer:backend mapping since frameworks handle inbound requests, not outbound. SSRF is correctly attributed via function:http-client on the actual HTTP client libraries (requests, axios, faraday, etc). Extracted resolveThreats helper to keep ThreatModel under the gocognit limit after adding the two-pass stack filtering. Closes #41, closes #42, closes #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three improvements from testing against real projects.
Stack filtering (#41): Only tools that fire a threat mapping or carry sinks appear in the stack. Bundler, Docker, CI, linters etc are trimmed. ecosystem-dashboard goes from 16 stack entries to 7.
Empty message (#42): Shows detected ecosystems and stack before saying "No threat categories match the detected stack" instead of the old "No security data available" which implied brief had no data.
SSRF mapping (#45): Removed from `role:framework + layer:backend` since frameworks handle inbound requests. SSRF is correctly attributed via `function:http-client` on actual HTTP client libs (requests, axios, faraday).
Closes #41, #42, #45