Fix container blob caching by passing auth token to fetcher#44
Merged
Conversation
The container handler was calling GetOrFetchArtifactFromURL without authentication headers, causing Docker Hub to return 401. The fallback proxyBlobWithAuth path had auth but bypassed the cache entirely. Now passes the Bearer token through GetOrFetchArtifactFromURLWithHeaders so blobs are both authenticated and cached. Fixes #43
Replace pre-release pseudo-version with the released v0.4.0 now that git-pkgs/registries#13 has been merged.
andrew
force-pushed
the
fix-container-blob-caching-auth
branch
from
09bc3ce to
7b02003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container handler was calling
GetOrFetchArtifactFromURLwithout authentication headers, causing Docker Hub to return 401. The fallbackproxyBlobWithAuthpath had auth but bypassed the cache entirely.Now passes the Bearer token through
GetOrFetchArtifactFromURLWithHeadersso blobs are both authenticated and cached.Fixes #43