Fix all golangci-lint warnings with extended linters#12
Merged
Conversation
Extract magic numbers to named constants for timeouts, retry params, connection pool sizes, and backoff factors. Use net/http status constants instead of raw integers. Fix potential panic in hackage cabal dependency parser where strings.Index could return -1. Refactor parseCabalFile to reduce cognitive complexity by extracting helper functions. Rewrite if-else chain as switch in urlparser. Use strings.Cut where appropriate. Add nolint directives for idiomatic patterns (SplitN with 2, interface returns from factory functions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all 52 warnings from golangci-lint run with gocritic, gocognit, gocyclo, maintidx, dupl, mnd, unparam, ireturn, goconst, and errcheck enabled.